-
-
Notifications
You must be signed in to change notification settings - Fork 335
Create pocketid.subdomain.conf.sample #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
|
||
| server { | ||
| listen 443 ssl; | ||
| listen 443 quic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not enable by default
| listen 443 ssl; | ||
| listen 443 quic; | ||
| listen [::]:443 ssl; | ||
| listen [::]:443 quic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not enable by default
| # enable for Tinyauth (requires tinyauth-location.conf in the location block) | ||
| #include /config/nginx/tinyauth-server.conf; | ||
|
|
||
| if ($lan-ip = yes) { set $geo-whitelist yes; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont know that users want geoblocking or have the mod to support it
| #include /config/nginx/tinyauth-server.conf; | ||
|
|
||
| if ($lan-ip = yes) { set $geo-whitelist yes; } | ||
| if ($geo-whitelist = no) { return 404; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you dont know that users want geoblocking or have the mod to support it
drizuid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review how we handle proxy confs and address the numerous issues here.
do
| set $upstream_proto http; | ||
| proxy_pass $upstream_proto://$upstream_app:$upstream_port; | ||
|
|
||
| ## Version 2023/02/09 - Changelog: https://github.com/linuxserver/docker-swag/commits/master/root/defaults/nginx/proxy.conf.sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure what you're doing here, but this doesn't belong in this file and it's highly unlikely we would make overarching changes to proxy.conf which affects everything.
Description
Benefits of this PR and context
How Has This Been Tested?
Source / References