Skip to content

Conversation

@id4vip
Copy link

@id4vip id4vip commented Dec 11, 2025

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description

Benefits of this PR and context

How Has This Been Tested?

Source / References


server {
listen 443 ssl;
listen 443 quic;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not enable by default

listen 443 ssl;
listen 443 quic;
listen [::]:443 ssl;
listen [::]:443 quic;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do not enable by default

# enable for Tinyauth (requires tinyauth-location.conf in the location block)
#include /config/nginx/tinyauth-server.conf;

if ($lan-ip = yes) { set $geo-whitelist yes; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont know that users want geoblocking or have the mod to support it

#include /config/nginx/tinyauth-server.conf;

if ($lan-ip = yes) { set $geo-whitelist yes; }
if ($geo-whitelist = no) { return 404; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you dont know that users want geoblocking or have the mod to support it

Copy link
Member

@drizuid drizuid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please review how we handle proxy confs and address the numerous issues here.
do

set $upstream_proto http;
proxy_pass $upstream_proto://$upstream_app:$upstream_port;

## Version 2023/02/09 - Changelog: https://github.com/linuxserver/docker-swag/commits/master/root/defaults/nginx/proxy.conf.sample
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure what you're doing here, but this doesn't belong in this file and it's highly unlikely we would make overarching changes to proxy.conf which affects everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants